Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncatchable rejected promise #73

Open
jeffrson opened this issue May 3, 2022 · 3 comments
Open

Uncatchable rejected promise #73

jeffrson opened this issue May 3, 2022 · 3 comments

Comments

@jeffrson
Copy link
Contributor

jeffrson commented May 3, 2022

When the SFTP server disconnects during ("extended") connection handshake (requesting the sftp subsystem) the client application stops due to unhandled promise rejection. The promise in question is rejected in https://github.com/sanketbajoria/ssh2-promise/blob/master/src/sshConnection.ts#L80

I created a pull request that should fix the problem: #72 - it enables the application to catch the rejected promise, which was otherwise impossible.

@sanketbajoria
Copy link
Owner

@jeffrson
This pull request has been merged. Can you please verify, if things are working good

@sebasptsch
Copy link

@sanketbajoria Does a new release need to be created?

@sanketbajoria
Copy link
Owner

@sebasptsch
Published a new release https://www.npmjs.com/package/ssh2-promise/v/1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants