Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This template isn't working for persons with Astro 4 #37

Open
narration-sd opened this issue Jan 9, 2024 · 2 comments
Open

This template isn't working for persons with Astro 4 #37

narration-sd opened this issue Jan 9, 2024 · 2 comments

Comments

@narration-sd
Copy link

narration-sd commented Jan 9, 2024

The template builds and operates as-is, but when persons upgrade it to use latest packages, including Astro 4 and @sanity/astro to accompany that, there are multiple failures.

To reproduce, run ncu -u from the top folder, and then attempt npm run dev, or npm run build.

Expected, is that with current packages, the template should just work.

I've created a fork with upgrades to fit the current software, available on branch main to make it easy to use. I'm not presenting a PR for these yet, because they necessarily use a temporarily published upgrade of @sanity/astro, on @narration-sd/santy-astro.

When its PR for official @sanity/astro resolves, I'll update the fork, and PR this repo for a completed result, reporting again here also.

@narration-sd narration-sd changed the title template isn't working for persons with Astro 4 This template isn't working for persons with Astro 4 Jan 9, 2024
@vmitsaras
Copy link

https://github.com/narration-sd/sanity-template-astro-clean
Is there any progress being made towards a merge?

@narration-sd
Copy link
Author

narration-sd commented Feb 6, 2024

Hi Vaslis @vmitsaras, in fact I've just last night released the PR here: #40.

You can work from the upgraded version for now which others have, as I think it's pretty solid.

This offers a much nicer experience I think, beside including Astro 4, along with all dependencies at latest code date up to now.

As you can read, the final PR needs another PR to be approved so its results can be included, and hopefully this one will follow that very shortly in the progress priority at Sanity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants