Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration into another program #6

Open
TechMagister opened this issue Jan 2, 2017 · 3 comments
Open

Integration into another program #6

TechMagister opened this issue Jan 2, 2017 · 3 comments

Comments

@TechMagister
Copy link

Hello,

For now sentry can just be run alone. It would be great to have the possibility to embed it into another program.

Because for now I have to reproduce the options and run sentry in another process : kemalyst-generator/commands/watch.cr

@samueleaton
Copy link
Owner

I was waiting for shards to add the feature where it can run build commands after installing a dependency. See crystal-lang/shards#124 and crystal-lang/shards#126.

I am doing some dynamic things when people run the install script:

curl -fsSLo- https://raw.githubusercontent.com/samueleaton/sentry/master/install.rb | ruby

You can look at the install.rb script to see whats going on.

But I think there may be something I can do—some refactoring perhaps. I think I can make the [app_name] that appears in sentry.cr be dynamic on run time or be able to be overridden by an argument.

@samueleaton
Copy link
Owner

@TechMagister let me know if your issue is resolved or if there anything else I need to add.

@TechMagister
Copy link
Author

With the pr #8 , the [process_name] is taken dynamically from shard.yml
It is perfect for me, let's see if it doesn't break anything for current users ( it should not ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant