Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev directory not cleaned up #45

Open
jgillich opened this issue Nov 25, 2019 · 1 comment
Open

dev directory not cleaned up #45

jgillich opened this issue Nov 25, 2019 · 1 comment

Comments

@jgillich
Copy link
Contributor

The install script creates a dev directory with the Sentry code and never cleans it up. I also think a different more random name would be better since dev is an incredibly common word.

I could submit a PR if that's cool with you.

@samueleaton
Copy link
Owner

sorry. finally responding to old issues.

Well, there are a few common scenarios where you wouldn't want to delete the sentry source files. The source files can be used to generate a new sentry executable if you want to develop on a different machine or in a VM.

Personally, I develop in Docker on a Mac, so I download Sentry on my Mac, and then pass the dev folder into Docker and recompile Sentry from within docker. The executable that Crystal generated on my mac wouldn't be usable within docker, and I wouldn't have the source files to generate a new one.

I could have it part of my docker image to always download the latest sentry version, but thats not as clean as having working source code already in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants