Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing version on shard.yml #29

Open
faustinoaq opened this issue Jun 21, 2018 · 9 comments
Open

Missing version on shard.yml #29

faustinoaq opened this issue Jun 21, 2018 · 9 comments

Comments

@faustinoaq
Copy link

Hi @samueleaton

I see you released sentry v0.3.0, although, shard.yml still says v0.2.0, see: https://github.com/samueleaton/sentry/blob/v0.3.0/shard.yml#L2

Can you delete v0.3.0 and create it again including the version change on shard.yml?

@samueleaton
Copy link
Owner

fixed. thanks for keeping me in line. do you know what the standard practice is for other Crystal projects so there is less human error?

@faustinoaq
Copy link
Author

@samueleaton Sure, I use shard check on CI to ensure all dependencies tags are ok 😉

@faustinoaq
Copy link
Author

@samueleaton Oh, I''m getting this error now: (no idea why 😅 )

myapp1 git:(master) ✗ shards                
Fetching https://github.com/faustinoaq/sentry-run.git
Fetching https://github.com/samueleaton/sentry.git
Failed git ls-tree -r --full-tree --name-only v1.0.0 -- shard.yml (). Maybe a commit, branch or file doesn't exist?

I'm using sentry as dependency here:https://github.com/faustinoaq/sentry-run/

@faustinoaq
Copy link
Author

I already cleaned up my shards cache 😅

@samueleaton
Copy link
Owner

do you think if i bumped the minor version it would fix it?

@faustinoaq
Copy link
Author

@samueleaton So weird, you have tagged sentry correctly, I checked twice 😅

I tried to test only sentry as dependency (without sentry-run) and I still got this error:

➜  ~ crystal init app app02
    create  app02/.gitignore
    create  app02/.editorconfig
    create  app02/LICENSE
    create  app02/README.md
    create  app02/.travis.yml
    create  app02/shard.yml
    create  app02/src/app02.cr
    create  app02/src/app02/version.cr
    create  app02/spec/spec_helper.cr
    create  app02/spec/app02_spec.cr
Initialized empty Git repository in /home/main/app02/.git/
➜  ~ cd app02 
➜  app02 git:(master) ✗ nano shard.yml 
➜  app02 git:(master) ✗ shards
Fetching https://github.com/samueleaton/sentry.git
Failed git ls-tree -r --full-tree --name-only v1.0.0 -- shard.yml (). Maybe a commit, branch or file doesn't exist?

@ysbaddaden any idea what is happening here? 😅

@faustinoaq
Copy link
Author

I just found the issue (mentioned by @hmans on gitter)

@samueleaton You have a 1.0.0 tag here: https://github.com/samueleaton/sentry/releases/tag/1.0.0

Can you remove it? 😅

@faustinoaq faustinoaq reopened this Jun 23, 2018
@hmans
Copy link

hmans commented Jun 23, 2018

I ended up forking this repo and removing the 1.0.0 tag from my fork, so I can confirm this will fix the issue.

@ysbaddaden
Copy link

Can you open an issue in Shards about this? It shouldn't be confused by tags that don't start with v :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants