Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function level keep_result_s not respected for errors #417

Open
SoftMemes opened this issue Oct 22, 2023 · 0 comments
Open

Function level keep_result_s not respected for errors #417

SoftMemes opened this issue Oct 22, 2023 · 0 comments

Comments

@SoftMemes
Copy link

In finish_failed_job, there's only a check on self.keep_result_s, not the value configured from the function. As a result, any failed tasks are stored for potentially a very long time and cannot be re-enqueued with the same job id, even if configured on the function level to not store a result.

This also relates to #416 as currently it's impossible to follow this pattern for tasks that can fail, e.g. trying to re-enqueue a task that you want to have eventually succeed does nothing of the worker is configured to keep values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant