Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selective Sync is not sorted correctly #1012

Open
stevetranby opened this issue Dec 25, 2023 · 1 comment
Open

Selective Sync is not sorted correctly #1012

stevetranby opened this issue Dec 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@stevetranby
Copy link

stevetranby commented Dec 25, 2023

Describe the bug
When viewing the selective sync GUI where it shows the files and folders with checkboxes showing whether its being synced to this device or not (but does show all that available in the Dropbox online). I don't care if Capitalized letters sort together amongst the lowercase versions (ie: a,A,b,B,c,C) or sorted separately (ie: a,b,c,A,B,C), but my version looks somewhat unsorted.

Incorrectly sorted (these are folders in my dropbox as shown in the list for choosing selected sync files and folders)
dev/
music/
Screenshots/
apps/
bin/
videos/
ebooks/
photos/
fonts/
wallpaper/

Both of these commands show the files and folders sorted correctly.
maestral excluded list
maestral ls

To Reproduce
Open preferences/settings, Choose "Select files and folders...", see how files and folders are not all sorted correctly, assuming you have enough files and folders to test.

Expected behaviour
I would expect it to match the sorting of either the Dropbox Online Website "All Files" view, or the native platform's file explorer (Finder, Window Explorer, ls, etc)

System:

  • Maestral version: 1.8.0 (93)
  • Python version: 3.11.4
  • OS: macOS 13.6.1
  • Desktop environment: Finder
  • PyQt version (for Linux GUI): n/a

Additional context
This is separate from a feature enhancement to allow clicking on the heading for "Name" and "Included" to sort by Name as ascending or descending.

@stevetranby stevetranby added the bug Something isn't working label Dec 25, 2023
@samschott
Copy link
Owner

Thanks for the report! Items are indeed sorted alphabetically, ignoring case, but only if the number of items in a folder is not too large. Once the Dropbox API starts returning remote items in batches, each new batch will be appended to the list once retrieved. This makes the UI appear to react quicker in case of large remote folders.

Currently, instead of inserting the items individually in their correct alphabetical place, they are all just appended. This could potentially be improved, if performance does not suffer too much from that, or we could pre-fetch the entire content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants