Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 3006.7 apt pkg.install with HTTP URL as source fails, if URL contains a equal sign #66443

Open
Deshke opened this issue Apr 26, 2024 · 0 comments
Labels
Bug broken, incorrect, or confusing behavior

Comments

@Deshke
Copy link

Deshke commented Apr 26, 2024

Description
similar to #64516 pkg.install fails if the url contains a = sign

Setup

salt-minion --versions
Salt Version:
          Salt: 3006.7

Python Version:
        Python: 3.10.13 (main, Feb 19 2024, 03:31:20) [GCC 11.2.0]

Dependency Versions:
          cffi: 1.14.6
      cherrypy: 18.6.1
      dateutil: 2.8.1
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.1.3
       libgit2: Not Installed
  looseversion: 1.0.2
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 22.0
     pycparser: 2.21
      pycrypto: Not Installed
  pycryptodome: 3.19.1
        pygit2: Not Installed
  python-gnupg: 0.4.8
        PyYAML: 6.0.1
         PyZMQ: 23.2.0
        relenv: 0.15.1
         smmap: Not Installed
       timelib: 0.2.4
       Tornado: 4.5.3
           ZMQ: 4.3.4

System Versions:
          dist: ubuntu 22.04.4 jammy
        locale: utf-8
       machine: x86_64
       release: 5.15.0-105-generic
        system: Linux
       version: Ubuntu 22.04.4 jammy

Steps to Reproduce the behavior

some-id:
  pkg.installed:
    - skip_verify: True
    - sources:
      - some-deb-file: "https://some-fqdn.tld/api/v4/projects/974/packages/generic/package/69be67e6/some-deb-file.deb.deb?private_token=abcd"

results in

[DEBUG   ] Requesting URL https://some-fqdn.tld/api/v4/projects/974/packages/generic/package/69be67e6/some-deb-file.deb.deb?private_token=abcd using GET method
[DEBUG   ] Using backend: tornado
/opt/saltstack/salt/lib/python3.10/site-packages/salt/ext/tornado/netutil.py:493: DeprecationWarning: ssl.PROTOCOL_TLS is deprecated
  context = ssl.SSLContext(
[INFO    ] Executing command dpkg in directory '/root'
[INFO    ] Executing command apt-get in directory '/root'
[INFO    ] Executing command dpkg in directory '/root'
[INFO    ] Executing command systemd-run in directory '/root'
[ERROR   ] Command 'systemd-run' failed with return code: 100
[ERROR   ] stdout: Reading package lists...
[ERROR   ] stderr: Running scope as unit: run-rae376bce525b4339bbb7b63469bfa995.scope
E: Unsupported file /var/cache/salt/minion/extrn_files/base/some-fqdn.tld/api/v4/projects/974/packages/generic/package/69be67e6/some-deb-file.deb.deb-private_token=abcd given on commandline
[ERROR   ] retcode: 100
[INFO    ] Executing command dpkg-query in directory '/root'
[ERROR   ] Problem encountered installing package(s). Additional info follows:

errors:
    - Running scope as unit: run-rae376bce525b4339bbb7b63469bfa995.scope
      E: Unsupported file /var/cache/salt/minion/extrn_files/base/some-fqdn.tld/api/v4/projects/974/packages/generic/package/69be67e6/some-deb-file.deb.deb-private_token=abcd given on commandline
[INFO    ] Completed state [some-id] at time 08:22:08.585874 (duration_in_ms=3003.202)

but this worked in 3005.x

Expected behavior

pkg.install does not fail

Additional context
Add any other context about the problem here.

@Deshke Deshke added Bug broken, incorrect, or confusing behavior needs-triage labels Apr 26, 2024
@dwoz dwoz removed the needs-triage label May 1, 2024
@dwoz dwoz added this to the Sulfur v3006.9 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior
Projects
None yet
Development

No branches or pull requests

2 participants