Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version mismatch warning should warn for patch version differences as well #4211

Closed
nolanlawson opened this issue May 13, 2024 · 2 comments
Closed
Labels
enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation

Comments

@nolanlawson
Copy link
Contributor

Here:

const [expectedMajor, expectedMinor] = LWC_VERSION.split('.');
if (major !== expectedMajor || minor !== expectedMinor) {

We check if the LWC compiler major/minor version differs from the engine major/minor version. Really we should just check if the versions are exactly the same or not, since we are just following basic semver from now on and make no guarantees about ABI compatibility between the engine and compiler for different versions.

@nolanlawson nolanlawson added enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation labels May 13, 2024
@SourabhMulay
Copy link
Contributor

SourabhMulay commented May 21, 2024

Hey @nolanlawson ,
I have raised a PR for this issue. please verify the changes.
#4216

@nolanlawson
Copy link
Contributor Author

Fixed by #4216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Up for grabs Issues that are relatively small, self-contained, and ready for implementation
Projects
None yet
Development

No branches or pull requests

2 participants