Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left over files on removal (feature request) #7

Open
edp17 opened this issue Jul 29, 2020 · 1 comment
Open

Left over files on removal (feature request) #7

edp17 opened this issue Jul 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@edp17
Copy link

edp17 commented Jul 29, 2020

When I uninstall the harbour-containers app, it leaves some files in the '/usr/share/harbour-containers/service/libs/__ pycache__':
init.cpython-38.pyc
lxc.cpython-38.pyc
qxcompositor.cpython-38.pyc
It also leaves the configuration of the created container in the '/var/lib/lxc/' folder and doesn't remove the files from the '/home/.lxc' folder.
I know these folders/files are kept because of SFOS' uninstall working order, but if you could include a button that runs a script, that is doing housekeeping before somebody decides to uninstall the app, that would be beneficial. (The downloaded data in 'home/.lxc' can be painful as eating a lot of storage.)

@Kabouik
Copy link
Member

Kabouik commented Jul 29, 2020

I agree about the .pyc file, but isn't it standard to keep configuration files and data files when uninstalling? pkgbuild even has a macro for configuration files to identify them and protect them from deletion at uninstall. Default configuration files sure should be removed, but all configuration files here are tied to container names, and hence could be considered customized by user (mine is actually customized anyway because I added mount points).

Files in /home/.lxc/ are data files in my opinion, and I'm not sure it would be good to have them deleted with no prior notice at uninstall, people would expect to find them again if they reinstall the application. They would not only lose the data they have in the container, but everything they set up, installed and configured too. To me the rootfs in /home/.lxc/ are pretty much like .img or .vbox files for VMs, they should persist even if the VM application is uninstalled.

However I agree that scripts/buttons to help cleaning for anyone wanting a full uninstall could be useful. I believe the Settings > Destroy container button is already doing that for /home/.lxc/containername, but it will work only for containers listed in the application, and hence would probably not be possible if the corresponding configuration file in /var/lib/lxc/ has already been removed or moved. Actually, does the Destroy button delete the configuration file too? I didn't test that.

@r3vn r3vn added the enhancement New feature or request label Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants