Do we need to deploy a new NFTDescriptor for V2.2?

[PaulRBerg]

This is a question for you @smol-ninja and @andreivladbrg.

If we could avoid deploying the NFTDescriptor, we would save quite a bit of ETH in deployment costs.

Speaking of this, it might be helpful to write one or two migration tests showing that V2.2 can be integrated with the previous NFTDescriptor deployment.

[smol-ninja]

NFTDescriptor is backward compatible with the previous versions. However we've made the following changes to the NFTDescriptor:

• Adds isTransferable value to NFT description.
• new NFT symbol: SAB-V2-LOCKUP-TRA

Do you still want to have tests written showing that its backward compatible?

[PaulRBerg]

Got it.In this case, we will have to make a new deployment.

And yes, we also want to write backward compatibility tests to show that the new NFT descriptor is compatible with the previous deployments

[smol-ninja]

Related: #881 (comment)

While working on this, I came to realize the new NFTDescriptor is not compatible with v2.0 but only with v2.1. This is due to the fact the new NFTDescriptor includes isTransferable in the svg description. v2.0 doesn't have isTransferable.

v2-core/src/SablierV2NFTDescriptor.sol

Line 96 in 76e29fe

isTransferable: vars.sablier.isTransferable(streamId)