-
-
Notifications
You must be signed in to change notification settings - Fork 60
/
SubstituteCompositeExpressionAddMethodsRector.php
115 lines (101 loc) · 3.11 KB
/
SubstituteCompositeExpressionAddMethodsRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
<?php
declare(strict_types=1);
namespace Ssch\TYPO3Rector\TYPO312\v0;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr\Assign;
use PhpParser\Node\Expr\MethodCall;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Deprecation-97244-CompositeExpressionMethodsAddAndAddMultiple.html
* @see \Ssch\TYPO3Rector\Tests\Rector\v12\v0\typo3\SubstituteCompositeExpressionAddMethodsRector\SubstituteCompositeExpressionAddMethodsRectorTest
*/
final class SubstituteCompositeExpressionAddMethodsRector extends AbstractRector
{
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
if (! $this->isNames($node->name, ['add', 'addMultiple'])) {
return null;
}
if ($this->isName($node->name, 'addMultiple')) {
/** @var Arg $arg */
$arg = $node->getArgs()[0];
$argValue = $arg->value;
$arguments = [new Arg($argValue, false, true)];
} else {
$arguments = $node->args;
}
return new Assign($node->var, $this->nodeFactory->createMethodCall($node->var, 'with', $arguments));
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Replace add() and addMultiple() of CompositeExpression with with()', [new CodeSample(
<<<'CODE_SAMPLE'
$compositeExpression = CompositeExpression::or();
$compositeExpression->add(
$queryBuilder->expr()->eq(
'field',
$queryBuilder->createNamedParameter('foo')
)
);
$compositeExpression->addMultiple(
[
$queryBuilder->expr()->eq(
'field',
$queryBuilder->createNamedParameter('bar')
),
$queryBuilder->expr()->eq(
'field',
$queryBuilder->createNamedParameter('baz')
),
]
);
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
$compositeExpression = CompositeExpression::or();
$compositeExpression = $compositeExpression->with(
$queryBuilder->expr()->eq(
'field',
$queryBuilder->createNamedParameter('foo')
)
);
$compositeExpression = $compositeExpression->with(
...[
$queryBuilder->expr()->eq(
'field',
$queryBuilder->createNamedParameter('bar')
),
$queryBuilder->expr()->eq(
'field',
$queryBuilder->createNamedParameter('baz')
),
]
);
CODE_SAMPLE
)]);
}
private function shouldSkip(MethodCall $method): bool
{
return ! $this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType(
$method,
new ObjectType('TYPO3\CMS\Core\Database\Query\Expression\CompositeExpression')
);
}
}