-
-
Notifications
You must be signed in to change notification settings - Fork 60
/
ReplaceExpressionBuilderMethodsRector.php
82 lines (72 loc) · 2.15 KB
/
ReplaceExpressionBuilderMethodsRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
<?php
declare(strict_types=1);
namespace Ssch\TYPO3Rector\TYPO312\v0;
use PhpParser\Node;
use PhpParser\Node\Expr\MethodCall;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Deprecation-97354-ExpressionBuilderMethodsAndXAndOrX.html
* @see \Ssch\TYPO3Rector\Tests\Rector\v12\v0\typo3\ReplaceExpressionBuilderMethodsRector\ReplaceExpressionBuilderMethodsRectorTest
*/
final class ReplaceExpressionBuilderMethodsRector extends AbstractRector
{
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [MethodCall::class];
}
/**
* @param MethodCall $node
*/
public function refactor(Node $node): ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
if (! $this->isNames($node->name, ['andX', 'orX'])) {
return null;
}
$methodName = $this->isName($node->name, 'andX') ? 'and' : 'or';
return $this->nodeFactory->createMethodCall($node->var, $methodName, $node->args);
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition('Replaces ExpressionBuilder methods orX() & andX()', [new CodeSample(
<<<'CODE_SAMPLE'
$rows = $queryBuilder
->select(...)
->from(...)
->where(
$queryBuilder->expr()->andX(...),
$queryBuilder->expr()->orX(...)
)
->executeQuery()
->fetchAllAssociative();
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
$rows = $queryBuilder
->select(...)
->from(...)
->where(
$queryBuilder->expr()->and(...),
$queryBuilder->expr()->or(...)
)
->executeQuery()
->fetchAllAssociative();
CODE_SAMPLE
)]);
}
private function shouldSkip(MethodCall $methodCall): bool
{
return ! $this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType(
$methodCall,
new ObjectType('TYPO3\CMS\Core\Database\Query\Expression\ExpressionBuilder')
);
}
}