-
-
Notifications
You must be signed in to change notification settings - Fork 60
/
UnifiedFileNameValidatorRector.php
123 lines (106 loc) · 3.67 KB
/
UnifiedFileNameValidatorRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
<?php
declare(strict_types=1);
namespace Ssch\TYPO3Rector\TYPO310\v4;
use PhpParser\Node;
use PhpParser\Node\Expr\ConstFetch;
use PhpParser\Node\Expr\StaticCall;
use PHPStan\Type\ObjectType;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @changelog https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.4/Deprecation-90147-UnifiedFileNameValidator.html
* @see \Ssch\TYPO3Rector\Tests\Rector\v10\v4\UnifiedFileNameValidatorRector\UnifiedFileNameValidatorRectorTest
*/
final class UnifiedFileNameValidatorRector extends AbstractRector
{
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes(): array
{
return [ConstFetch::class, StaticCall::class];
}
/**
* @param ConstFetch|StaticCall $node
*/
public function refactor(Node $node): ?Node
{
if ($this->shouldSkip($node)) {
return null;
}
if ($node instanceof StaticCall && $this->isMethodVerifyFilenameAgainstDenyPattern($node)) {
return $this->nodeFactory->createMethodCall(
$this->nodeFactory->createStaticCall('TYPO3\CMS\Core\Utility\GeneralUtility', 'makeInstance', [
$this->nodeFactory->createClassConstReference('TYPO3\CMS\Core\Resource\Security\FileNameValidator'),
]),
'isValid',
$node->args
);
}
if ($this->isConstFileDenyPatternDefault($node)) {
return $this->nodeFactory->createClassConstFetch(
'TYPO3\CMS\Core\Resource\Security\FileNameValidator',
'DEFAULT_FILE_DENY_PATTERN'
);
}
return null;
}
public function getRuleDefinition(): RuleDefinition
{
return new RuleDefinition(
'GeneralUtility::verifyFilenameAgainstDenyPattern GeneralUtility::makeInstance(FileNameValidator::class)->isValid($filename)',
[
new CodeSample(
<<<'CODE_SAMPLE'
use TYPO3\CMS\Core\Utility\GeneralUtility;
$filename = 'somefile.php';
if (!GeneralUtility::verifyFilenameAgainstDenyPattern($filename)) {
}
if ($GLOBALS['TYPO3_CONF_VARS']['BE']['fileDenyPattern'] != FILE_DENY_PATTERN_DEFAULT)
{
}
CODE_SAMPLE
,
<<<'CODE_SAMPLE'
use TYPO3\CMS\Core\Resource\Security\FileNameValidator;
use TYPO3\CMS\Core\Utility\GeneralUtility;
$filename = 'somefile.php';
if (!GeneralUtility::makeInstance(FileNameValidator::class)->isValid($filename)) {
}
if ($GLOBALS['TYPO3_CONF_VARS']['BE']['fileDenyPattern'] != FileNameValidator::DEFAULT_FILE_DENY_PATTERN)
{
}
CODE_SAMPLE
),
]
);
}
/**
* @param ConstFetch|StaticCall $node
*/
public function isMethodVerifyFilenameAgainstDenyPattern($node): bool
{
return $node instanceof StaticCall && $this->nodeTypeResolver->isMethodStaticCallOrClassMethodObjectType(
$node,
new ObjectType('TYPO3\CMS\Core\Utility\GeneralUtility')
) && $this->isName($node->name, 'verifyFilenameAgainstDenyPattern');
}
/**
* @param ConstFetch|StaticCall $node
*/
private function shouldSkip($node): bool
{
if ($this->isMethodVerifyFilenameAgainstDenyPattern($node)) {
return false;
}
return ! $this->isConstFileDenyPatternDefault($node);
}
/**
* @param ConstFetch|StaticCall $node
*/
private function isConstFileDenyPatternDefault($node): bool
{
return $node instanceof ConstFetch && $this->isName($node->name, 'FILE_DENY_PATTERN_DEFAULT');
}
}