Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-act-class is not enough #41

Open
jackprogramsjp opened this issue Aug 4, 2023 · 2 comments
Open

data-act-class is not enough #41

jackprogramsjp opened this issue Aug 4, 2023 · 2 comments

Comments

@jackprogramsjp
Copy link

This package is VERY non-customizable.

What if I wanted to use data-act-class for an attribute, for example? Like, set an attribute to true when activated. You can't. You are forced to use data-act-class.

Either have a callback listener for active through JavaScript, or have a data-act-attribute for an attribute as well!
@jackprogramsjp
Copy link
Author

jackprogramsjp commented Aug 4, 2023 •
edited

Instead of hassling around with this, it's better if you just create your own theme switch if you are using attributes, or any other information, instead of data-act-class.

@jackprogramsjp jackprogramsjp reopened this Aug 4, 2023
@saadeghi
Copy link
Owner

saadeghi commented Aug 4, 2023

I agree.
However I'm busy with daisyUI issues and improvements and I'm not sure when I will have free time to add this feature.

Any help is appreciated and PRs are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saadeghi @jackprogramsjp