-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.1/8.2 warnings and errors #800
Comments
(The happy smiley is about the mentioned other fixes ;) ) Let's make sure I understand this correctly: The DELETE deletes everything with 'base_property' with an empty subgroup. So all following INSERTs where the subgroup is empty can work (as the property differs), but the failing one can not because the subgroups is 'internal' -> it was not deleted before and still exists, the index complains. If that's the case I would also doubt that this works in 2.4.0 (you already confirmed it does?) |
Yes, exactly. |
I'm currently working on PHP 8.2 support. The biggest problems and errors are already fixed 馃殌
There are many smaller warnings and errors waiting for fixes.
Currently I'm stuck on updating media properties.
To reproduce: Edit any media and click safe. The following SQL statements will be executed:
First the (sub)groups
'base_property' / ''
values are deleted, then'base_property' / ''
values are written - but also'base_property' / 'internal'
values. That can't work (same for 2.4.0) because of the unique indexmedia_idx
(mediaid
,property
,property_group
,property_subgroup
).The relevant code is located here:
include/admin/images.inc.php: serendipity_parsePropertyForm()
include/functions_images.inc.php: serendipity_insertMediaProperty()
include/functions_images.inc.php: serendipity_db_query()
Thanks for any contributions - also for information how 2.4.0 can execute the same code without crashing.
The text was updated successfully, but these errors were encountered: