Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop undocumented [0] grabs #10

Open
ryanve opened this issue Dec 16, 2013 · 1 comment
Open

Drop undocumented [0] grabs #10

ryanve opened this issue Dec 16, 2013 · 1 comment

Comments

@ryanve
Copy link
Owner

ryanve commented Dec 16, 2013

verge methods that accept (element [, cushion]) expect element to be native DOM element. Under the hood the 1.x code actually allows element to be an array-like object, in which case the first item is used. This was never a recommended syntax. I had kept it in there for back support just in case. Does anyone use this syntax? If not, I think we could safely remove it in a later minor or major version.

@ryanve
Copy link
Owner Author

ryanve commented Feb 2, 2014

Actually this is briefly documented:

Test if any part of an element (or the first element in a matched set) is in the current viewport.

I still in favor of the simplification but the change should wait until 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant