Add binary on flathub

[roukmoute]

I've seen there is a flatpak ready.

Is it possible to add it on flathub?

Thanks in advance

[Root-Core]

Just to channel the discussion so far I will add some quotes.

Quote @rustdesk:

The Flatpak version can not be used as controlled side, the container (sandbox) has big limitation to us.

Quote @rustdesk:

So flatpak can not be used as controlled side.

---

I think there is a major misconception, mistake or miscommunication.
Flatpack does not allow the implementation of daemons, while Snap does.

@rustdesk thinks this (or the sandboxing) makes the implementation of the ability to control the system running the Flatpack version impossible.

---

On the other hand, there is AnyDesk on Flathub, which just does this.
They have implemented the "daemon" into a tray icon, which stays in backgrounds and listens for incoming requests.
This seems to be a viable solution for this problem and to me like the preferred implementation anyways.

---

At this point it is not clear what exactly hinders the implementation or how AnyDesk archives it.

[My1]

I might wanna link the flathub anydesk repo which likely contains all the stuff they used to make anydesk into a flatpack from the outside
https://github.com/flathub/com.anydesk.Anydesk

[sandr01d]

Thanks for the summary @Root-Core. I think there are a few things I can add to this regarding what is still missing for flatpak support.

The manifest is ready. When building for flatpak, inline-sciter.py need to be run and the build needs to be made with --feature inline,flathub, so we'd need an extra flatpak release on the release page.

Currently rustdesk fails to determine the correct display server when run in a flatpak, because get_display_server_of_session() relies on loginctl, which isn't available in flatpak.

rustdesk/libs/hbb_common/src/platform/linux.rs

Line 9 in 551c5ec

if let Ok(output) = std::process::Command::new("loginctl")

I currently don't know how to solve this one, so if anyone has an idea, please let me know.

Regarding the system tray: This seems to be wanted for Linux anyway, since #809 has been added to #918. The crate that is currently used for a tray icon only supports Windows, but maybe the maintainers would be fine with replacing it with a crate that is multi platform? Also #912 could probably tackled with this one as well.

That being said, I personally think the flatpak could be shipped before system tray support on Linux is implemented. I can see some use cases where being able to run rustdesk in the background is not required.

[istori1]

flatpak-spawn --host loginctl

For that to work this permission is needed
- --talk-name=org.freedesktop.Flatpak

[rustdesk]

@Kingtous

[sandr01d]

flatpak-spawn --host loginctl

For that to work this permission is needed - --talk-name=org.freedesktop.Flatpak

Thanks for the input @istori1! I've created #1731 to implement this. Are you sure - --talk-name=org.freedesktop.Flatpak is needed? I'm asking because it seems to work fine without it.

[My1]

as a SteamDeck user I would also greatly think this as an awesome idea. not sure how exactly anydesk works but it certainly works, and an open source relay-compatible application that can run on multiplatform is something way too rare imo

[roukmoute]

as a SteamDeck user I would also greatly think this as an awesome idea. not sure how exactly anydesk works but it certainly works, and an open source relay-compatible application that can run on multiplatform is something way too rare imo

It is currently not possible for me to use rustdesk, but if you would like to use another, you can use NoMachine, I explain how here: https://www.reddit.com/r/SteamDeck/comments/x9pe5y/comment/iq33k76/?utm_source=share&utm_medium=web2x&context=3

[My1]

or I can use anydesk for now which not only plain works as a flatpak, but crucially doesnt need to disable the os-readonly which (notably) protects partitions that are axed upon update. I dont wanna get weird problems because stuff has gone missing after the update and it is needed for something and all that.

[istori1]

Also in Flatpak:
https://github.com/LizardByte/Sunshine

https://github.com/LizardByte/Sunshine/releases/download/v0.14.1/sunshine.flatpak

https://github.com/istori1/Easy-Tan#easy-tan-sunshine-quick-setup-for-linux

[jacobgonzales20]

I've seen there is a flatpak ready.

Is it possible to add it on flathub?

Thanks in advance

Waiting on this, too. The current beta 1.2.0 has flatpak, though it isn't submitted on Flathub

[sandr01d]

Can be found on the releases page as nightly:

https://github.com/rustdesk/rustdesk/releases

[p-fruck]

@rustdesk is there any update on this? From #3973 is seems like the flatpak will be working fine on multiple systems including the steam deck with the next release. Are there any considerations to publish the flatpak to some repository like flathub.org?

[tesfabpel]

As a user I believe it's better to have it on flathub (maybe marked as prerelease if possible...) and then fix the various issues later if the flatpak version is mostly+ working than not having it there at all. It's also better for Steam Deck users since the system is by default RO.

[My1]

since the system is by default RO.

not just that but enabling write can lead to more problems than it solves due to A/B Partitioning and likely image based updates.

[realitymolder]

Version 1.2.0 is out but no flatpak on flathub.

[tim77]

Precompiled binary not enough. Example of how to properly build canonical from sources Rust projects on Flathub:

• https://github.com/flathub/net.veloren.veloren
• https://github.com/flatpak/flatpak-builder-tools/tree/master/cargo

[mikelpr]

what is keeping it out from flathub now?

[rustdesk]

Thanks @Justinzobel @sandr01d @Root-Core

[rustdesk]

Would you be OK with me adding it?

Please go ahead, @Justinzobel

[rustdesk]

flutter

@sandr01d yes, and adding arm64

[LichiMan]

Hi! I'm very happy Rustdesk will finally arrive to Flathub.

Will the Flathub version be able to autostart the server at boot someway even without the needs to login first?
Is this possible?

Thanks.

[xlionjuan]

@LichiMan This is not how Flatpak works

[rustdesk]

flathub/flathub#5233

[Croydon]

Why would they require a certain branch? git tags represent versions

[FurtadoPires]

Probably because it's considered to be a good practice making master / main branch == latest stable release

It's common for users who prefer to compile / builder softwares / AUR maintainers to pull directly to the main branch of the repository, so developers usually put any new / not tested / incomplete code in other branches like beta / release candidate / etc.

Judging by how this repository is right now, I can guess that any modifications are being included directly to the master branch, which can result in a different build from the release version.

That's why I suggested the use of git flow (linked above) or another branch strategy that rustdesk developers feel comfortable to work with, because my guess is that flathub curators won't like the package not being build directly from master.

[Croydon]

Sorry, but I think your points are completely off-topic regarding putting Rustdesk on Flathub. Flatpaks on Flathub use most of the time specific stable versions and if not then some specific commit. Where the source downloads come from is irrelevant as long as they are official and stay unchanged, i.e. match the saved checksums.

Rustdesk's Flathub should stick to stable release versions as it also does with other downloads / installer / package formats. And what the work flow is in this main repository here does not matter for Flathub.

[FurtadoPires]

Sorry, but I think your points are completely off-topic regarding putting Rustdesk on Flathub.

So I check up the request, and one of the curators asked

why not building from source?

I know that's because it's being built using the deb file from 1.2.4 (which is not currently tagged as the stable) instead of directly from the source code.

To be clear, I'm not saying that's obligatory to do it, I'm saying that is considered a good practice and they may not like it (the way it's being doing right now). But if they accept without any changes in that part I mentioned then great, it means that it hopefully ready to be approved and maintained and my suggestion is pointless (as you stated).

[nalsai]

Flatpak does not require it to be built from source but you are supposed to do it if you can.

But what I believe Croydon was referring to is that there are no special changes needed for that.
It is enough to specify the tag 1.2.4 or the commit 9827c76.