Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspiration for more patterns #35

Closed
killercup opened this issue Oct 9, 2016 · 10 comments
Closed

Inspiration for more patterns #35

killercup opened this issue Oct 9, 2016 · 10 comments
Labels
M-move-to-discussions Meta: Label for converting issues to discussions
Projects

Comments

@killercup
Copy link

killercup commented Oct 9, 2016

I recently started collecting some API design patterns here. I'm not sure if these match what this repo is all about (or which ones you already cover), but I just wanted to say: Feel free to take anything you like from that post! :)

  • Public type aliases
  • Use conversion traits
  • Laziness: Use Iterators
  • Laziness: Take closures
  • Custom traits for input parameters
  • Extension traits
  • Builder pattern
  • Session types

(The markdown source of that post is here and I hereby relicense the content as MPL2 (in addition to CC-BY) and allow you to use it in this repo.)

@nrc
Copy link
Collaborator

nrc commented Oct 9, 2016

awesome, thanks!

@simonsan
Copy link
Collaborator

@simonsan simonsan added the C-needs discussion Area: Something that is not clear to everyone if it fixes something/adds valuable content label Dec 31, 2020
@MarcoIeni
Copy link
Collaborator

MarcoIeni commented Dec 31, 2020

Yeah, we don't want to overlap with the rust api guidelines (which is also linked in the killercup article).

Let's discuss each of those individually:

@simonsan simonsan pinned this issue Jan 2, 2021
@simonsan simonsan added this to To do in Content Jan 3, 2021
@simonsan
Copy link
Collaborator

simonsan commented Jan 6, 2021

Should we close this in favour of #116 ? I copied everything needed from this issue over.

@simonsan simonsan unpinned this issue Jan 6, 2021
@MarcoIeni
Copy link
Collaborator

In that issue the fact that these issues should be taken from that blog post is not clear in my opinion.
Anyway I prefer smaller issues with respect to big ones, because it is impossible to follow too many discussions at the same time. Maybe that issue could link to this one? 😅

@simonsan
Copy link
Collaborator

simonsan commented Jan 6, 2021

Agreed, discussions should still take place in smaller issues, it's an umbrella. i thought about opening an issue for each of the points in this issue actually. hence why i asked about closing. we could link from each of these issues to this one here to make clear, that there might be material taken from it

@MarcoIeni
Copy link
Collaborator

What you are suggesting is the opposite: too small issues 😂
I propose to keep the sub-issues as checklist (see the second comment) and split the discussion in different issues if and when needed :)

@simonsan
Copy link
Collaborator

simonsan commented Jan 6, 2021

Yeah, or even better use the discussion board for discussing how to write the patterns and keep the issues clean for actual issues, what do you think?

@MarcoIeni
Copy link
Collaborator

It depends for what you mean with "actual issues".

I think "discussions" are still in beta and they are more meant for "stack overflow" kind of random questions.
I wouldn't force users to use discussions over issues to express concerns about the content of this book.

@simonsan
Copy link
Collaborator

simonsan commented Jan 6, 2021

Yeah, let's see how it develops.

@simonsan simonsan moved this from To do to ToDo-Patterns in Content Jan 21, 2021
@simonsan simonsan added M-move-to-discussions Meta: Label for converting issues to discussions and removed C-needs discussion Area: Something that is not clear to everyone if it fixes something/adds valuable content labels Feb 22, 2021
Content automation moved this from ToDo-Patterns to Done Feb 22, 2021
@rust-unofficial rust-unofficial locked and limited conversation to collaborators Feb 22, 2021

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
M-move-to-discussions Meta: Label for converting issues to discussions
Projects
Development

No branches or pull requests

4 participants