Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark required rustc version #168

Open
Stebalien opened this issue Jun 16, 2016 · 5 comments
Open

Mark required rustc version #168

Stebalien opened this issue Jun 16, 2016 · 5 comments

Comments

@Stebalien
Copy link
Contributor

Something like:
rustc stable
rustc nightly

It would be nice to get crates.io support for this (rust-lang/crates.io#168) but that might take a while.

@luciusmagn
Copy link
Collaborator

If support for this was to be introduced to crates.io, I am all for, although it would require a lot of work to retroactively add the badges to older entries

@palfrey
Copy link
Collaborator

palfrey commented Jan 30, 2020

Once rust-lang/rust#65262 gets implemented we could possibly feed off that. Maybe write a tool to grab Cargo.toml files and look for the relevant field.

@Israel-Laguan
Copy link
Contributor

Once rust-lang/rust#65262 gets implemented we could possibly feed off that. Maybe write a tool to grab Cargo.toml files and look for the relevant field.

Just wanted to remind that the RFC was implemented

@palfrey
Copy link
Collaborator

palfrey commented Jan 18, 2023

Once rust-lang/rust#65262 gets implemented we could possibly feed off that. Maybe write a tool to grab Cargo.toml files and look for the relevant field.

Just wanted to remind that the RFC was implemented

Feel like writing the tool?

@Israel-Laguan
Copy link
Contributor

Israel-Laguan commented Jan 18, 2023

So I was checking the docs, seems like the idea of rust-lang/rust/issues/65262 is "Minimal Version" instead of "stable vs nightly".

Also, this solution is dependent on the field to be available in each repo. for example, the first item in the list, alacritty, doesn't have the field in the main cargo file.

The plans that I think right now are:

  1. Make PRs in each repo, asking to include the field rust-version to add a badge "MSRV 1.x.xx" or similar
  2. Wait until crates.io provides another way to check the rust version
  3. Manually add the badge by testing each repo, stating the time it was last tested

Personally vote for option 2. Also, if someone else has another plan of action would be good to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants