Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are self-approved PRs counted twice? #61

Open
RalfJung opened this issue May 14, 2024 · 0 comments
Open

Are self-approved PRs counted twice? #61

RalfJung opened this issue May 14, 2024 · 0 comments

Comments

@RalfJung
Copy link
Member

In Miri, I often self-approve PRs when I think they are sufficiently uncontroversial (which is most of them). The relevant commits and the bors commit with the approval then get synced to the rustc repo. If I understand the logic in this repo correctly, these PRs then count as one contribution by me for each commit, plus one contribution for the "review"? That doesn't seem entirely fair...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant