Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1611 #1620

Merged
merged 1 commit into from Sep 4, 2023
Merged

Fix 1611 #1620

merged 1 commit into from Sep 4, 2023

Conversation

mkovaxx
Copy link
Contributor

@mkovaxx mkovaxx commented Aug 10, 2023

Fixes #1611

@shadows-withal shadows-withal merged commit 6378c2a into rust-lang:main Sep 4, 2023
2 checks passed
@shadows-withal
Copy link
Member

@all-contributors please add @mkovaxx for content

@allcontributors allcontributors bot mentioned this pull request Sep 4, 2023
Merged
@allcontributors
Copy link
Contributor

@shadows-withal

I've put up a pull request to add @mkovaxx! 🎉

@MartinNowak
Copy link

MartinNowak commented Sep 7, 2023 •
edited

This broke the exercise and should be reverted, see #1611 (comment).
Seems the reference to the conditional .to_mut() call within abs_all is too subtle.

@pchilds
Copy link

pchilds commented Sep 18, 2023

@shadows-withal Please revert

@pchilds pchilds mentioned this pull request Sep 18, 2023
Open
@shadows-withal shadows-withal mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadows-withal shadows-withal shadows-withal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cow1.rs last test is missing to_mut
4 participants
@mkovaxx @shadows-withal @MartinNowak @pchilds