-
Notifications
You must be signed in to change notification settings - Fork 856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OR pattern in match
arm makes rustfmt
forget comment alignment
#6060
Labels
Comments
Thanks for the report. Yeah, there's something about the OR pattern that's throwing off the alignment. Without the OR pattern things align as you'd expect. Input: fn main() {
let error_code = match err {
msgs::DecodeError::UnknownVersion => 0x4000 | 1, // unknown realm byte
msgs::DecodeError::ShortRead => 0x4000 | 22, // invalid_onion_payload
_ => 0x2000 | 2, // Should never happen
};
} Output: fn main() {
let error_code = match err {
msgs::DecodeError::UnknownVersion => 0x4000 | 1, // unknown realm byte
msgs::DecodeError::ShortRead => 0x4000 | 22, // invalid_onion_payload
_ => 0x2000 | 2, // Should never happen
};
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When reformatting the following example:
we receive this result:
Note that the comment at the end of the second match arm is unaligned with the others. For the third match arm
rustfmt
even introduces many whitespaces to ensure it's aligned with the in the first match arm. However, it seems thatrustfmt
entirely forgets about this alignment in the second match arm, presumably due to it being an OR patternThis seems to happen independently from any particular config option or
rustfmt
version, but currently I'm usingThe text was updated successfully, but these errors were encountered: