Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io::Sink is useless since version 1.73 as io::Empty now has a superset of its features. #124538

Open
vidhanio opened this issue Apr 29, 2024 · 1 comment
Open

io::Sink is useless since version 1.73 as io::Empty now has a superset of its features. #124538

vidhanio opened this issue Apr 29, 2024 · 1 comment
Labels
A-io Area: std::io, std::fs, std::net and std::path C-discussion Category: Discussion or questions that doesn't represent real issues. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@vidhanio
Copy link
Contributor

Should the entire Sink/sink() api be deprecated with the changes brought to io::Empty?
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Apr 29, 2024
@vidhanio vidhanio changed the title io::Sink is useless since version 1.73 as io::Empty now has a superset of its' features. io::Sink is useless since version 1.73 as io::Empty now has a superset of its features. Apr 29, 2024
@Nilstrieb
Copy link
Member

It should maybe be "deprecated in future version" to stop people from newly using it (which is only mentioned in the docs).
I do not think there is any value for emitting warnings, which would be entirely useless churn.

@Nilstrieb Nilstrieb added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. C-discussion Category: Discussion or questions that doesn't represent real issues. A-io Area: std::io, std::fs, std::net and std::path and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-io Area: std::io, std::fs, std::net and std::path C-discussion Category: Discussion or questions that doesn't represent real issues. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vidhanio @rustbot @Nilstrieb