Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode search button colors too aggressive #8674

Open
alerque opened this issue May 18, 2024 · 3 comments
Open

Dark mode search button colors too aggressive #8674

alerque opened this issue May 18, 2024 · 3 comments

Comments

@alerque
Copy link

alerque commented May 18, 2024

The new dark mode is great to have, but some of the color choices are a bit jaring. It feels like some things are leftover from a different theme, not a design choice for the dark theme.

For example the search button in the header and home page is way too bright and overpowers everything on any page, including the logo.

image

In fact the other yellow button colors are much more subdued, some of them perhaps too muted and inconsistent:

image

Of these the two big buttons from the home page look about right, but the "follow" buttons seem too muted and the "search" buttons seem to bright.

@alerque alerque changed the title Dork mode search button colors too aggressive Dark mode search button colors too aggressive May 18, 2024
@rope-hmg
Copy link

I also find the text colour is too bright. And possibly the background is too dark?

image

@alerque
Copy link
Author

alerque commented May 24, 2024

@rope-hmg I would suggest a different issue, that's really a different discussion. Personally I think the contrast shown is fine and wouldn't want to see it muted more. This issue is about outliers that are outside the overall range of most of the theme.

@rope-hmg
Copy link

rope-hmg commented Jun 1, 2024

Ah yes. The dark mode is not good, but talking about how the dark mode isn't good isn't relevant. Yep, I see it.

Seems to me like it's very reasonable to mention some of the colour choices being too bright. Especially when you yourself said "but some of the color choices are a bit jaring".

Considering my complaint about these colours is the same as yours maybe this is the right issue to mention them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants