Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate form #424

Open
burrbull opened this issue Jan 7, 2020 · 1 comment · May be fixed by #430
Open

Integrate form #424

burrbull opened this issue Jan 7, 2020 · 1 comment · May be fixed by #430

Comments

@burrbull
Copy link
Member

burrbull commented Jan 7, 2020

What are you think about integrate form functionality in svd2rust (optional)?

When this option is enabled we can do not merge mod TokenStreams in one (and then split with form) and write them in different files directly. I think this can give us significant speed-up in this case.

@therealprof
@therealprof therealprof changed the title Intergate form Integrate form Jan 7, 2020
@therealprof
Copy link
Contributor

Yes, I was thinking about that. I was also looking into integrating with rustfmt directly since the generated code is such a hot mess; quite obviously the code generation/parsing cabilities of syn/quote/proc_macro2 were never meant to generate code stored to disk but only non-persistent code to be compiled on-the-fly.

@burrbull burrbull linked a pull request Jan 14, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modules (form) rust-embedded/svd2rust
2 participants
@burrbull @therealprof