-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riscv
: All the CSR write operations should be unsafe by default
#209
Comments
riscv
: All the CSR write operations should be unsafe by default
As I always do, I checked the In other words, I am in favor of your proposal. |
I agree. Writing to RISC-V CSRs can cause all sorts of |
We commented this issue in yesterday's meeting and the general impression is that we should:
|
In general we should assume that writing to CSRs could do something that potentially violates the Rust abstract model.
Macros like
write_csr_as
andwrite_csr_as_usize
should at least default tounsafe
, and maybe have an option to make a safe variant on a CSR by CSR basis.The text was updated successfully, but these errors were encountered: