[BUG] formfield type password length check

[falkheiland]

when adding a new app and defining a formfield for a long string as a password field - with or without the specification of min and max properties the error message

{{ formfieldname }} must be between and characters

is shown, an installation is not possible. the used length of the used string is 170 chars

[hex-developer]

The code for handling password length is here:

runtipi/src/app/(dashboard)/app-store/[id]/utils/validators/validators.ts

Lines 29 to 33 in 7c4bf34

	case 'password':
	if (!validator.isLength(value, { min: field.min || 0, max: field.max || 100 })) {
	return translator('APP_INSTALL_FORM_ERROR_BETWEEN_LENGTH', { label: field.label, min: field.min, max: field.max });
	}
	break;

If min was defined in the form field config, it's value is compared to the input length, otherwise it defaults to 0.
If max was defined in the form field config, it's value is compared to the input length, otherwise it defaults to 100.

If max isn't defined, it makes sense that a 170 char string won't be allowed. Otherwise, there shouldn't be a problem. Do you have a specific app with this issue?

[falkheiland]

when creating an oidc / oauth2 provider in authentik, then there is a client secret created, a string with 129 chars. if you want to create an app, which forces you to have an external auth and you want to support oidc and since this client secret is a secret, it should be treated / used as a password in tipi.

[hex-developer]

That is correct. Maybe that app's password length limit should be changed. You can open an issue on the app store repo.

[meienberger]

This should not be an issue if max is set to a higher number. Maybe there is a bug somewhere. Have you an app draft to share in which I could reproduce the issue?

[falkheiland]

That is correct. Maybe that app's password length limit should be changed. You can open an issue on the app store repo.

i just now really understood the reply, @hex-developer - sorry :(
if necessary i can recreate the issue. Update: you apparently can just move issue to other repos.

Have you an app draft to share in which I could reproduce the issue?

i changed that fields type in my example to get it working to a string - but i will make a new example / test app!

[falkheiland]

Test Branch:

https://github.com/falkheiland/runtipi-appstore/tree/issue/1336

Test-App:

outline-1 (outline without integrated oidc service, to use with external ones, like authentik etc.)

OIDC_CLIENT_SECRET:

I6jxaHDqtTNjPDxrVAeeZUzHytmZppSxhHyqX6swQx5L89kF0Tg2CQtIECHDkyk0naJglZtLWAGHz931X6FhhgKxxEOCgvf47O6eb9ZwZtdRYDblpPKhQhAz0v5RtJK4

[github-actions]

This issue is stale because it has been open for 30 days with no activity.

[steveiliop56]

@meienberger that happened due to the switch to the radix component.