[BUG] Data folder must be refreshed during update

[CiliaFred]

Checklist

Describe the bug
In case of update in an apps data folder, the update file are not copied to app-data folder.
This is due to the following code in file worker/src/services/app/app.executors.ts:

this.logger.info(`Copying data dir for app ${appId}`);
 if (!(await pathExists(`${appDataDirPath}/data`))) {
    await copyDataDir(appId);
}

If the content of data change, the data directory is not updated.

To Reproduce
Steps to reproduce the behavior:

1. Install an application in version 1
2. Add a data folder in a new version of the application
3. Update the application in version 2
4. The data folder content in application is not copied to app-data folder

[meienberger]

Thanks for opening the issue, I agree with you however how do we prevent this from overwriting customer user changes? Let's say you customize a config file in your app-data directory and update the app. Enabling this will destroy your changes

[CiliaFred]

I know, that's why i don't fix it directly.

It probably needs some refactoring.

[github-actions]

This issue is stale because it has been open for 30 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.

[github-actions]

This issue is stale because it has been open for 30 days with no activity.

[steveiliop56]

Hello,

The data folder is being used to copy initial configuration files. For example a default file needed for the app to start. We cannot copy the data folder again since it would overwrite the user data.