Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Parameterized Queries #38

Closed
abraithwaite opened this issue Feb 28, 2024 · 2 comments · Fixed by #49
Closed

Support for Parameterized Queries #38

abraithwaite opened this issue Feb 28, 2024 · 2 comments · Fixed by #49
Assignees
@zombiezen

Comments

@abraithwaite
Copy link
Contributor

We should figure out how to support parameterized queries for databases.

They have various distinct ways of being implemented that we should be able to support

We may be able to use the passthrough mechanisms plus some side-channel loading of parameters somehow, as an idea.
@zombiezen zombiezen self-assigned this Jun 3, 2024
@zombiezen
Copy link
Collaborator

@abraithwaite I think this makes the most sense to restrict to named parameters (as opposed to positional parameters), since I don't see a KQL syntax for positional parameters. Named parameters would behave like let parameters.

@zombiezen
Copy link
Collaborator

Ohh, Clickhouse's substitution is interesting: https://clickhouse.com/docs/en/sql-reference/syntax#defining-and-using-query-parameters

I suppose it makes the most sense to have that specified during compilation, not inside the expression itself.

zombiezen added a commit to zombiezen/pql that referenced this issue Jun 3, 2024
@zombiezen
Add named parameter compile option
58ad618 
This also introduces the notion of `CompileOptions`.
I was able to create a mechanism that avoids a dialect enum
while delivering a fairly straightforward API.

Fixes runreveal#38
@zombiezen zombiezen mentioned this issue Jun 3, 2024
Merged
zombiezen added a commit that referenced this issue Jun 11, 2024
@zombiezen
Merge pull request #49
a015aeb 
Add named parameter compile option.
This also introduces the notion of CompileOptions.
I was able to create a mechanism that avoids a dialect enum while delivering a fairly straightforward API.

Fixes #38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombiezen zombiezen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add named parameter compile option zombiezen/pql
2 participants
@zombiezen @abraithwaite