Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build.gradle in the templates should not pull in unversioned, remote code #7

Open
plambert opened this issue Oct 25, 2018 · 0 comments

Comments

@plambert
Copy link

From src/main/resources/templates/script-plugin/filecopier/build.gradle.template:

apply from: 'https://raw.githubusercontent.com/rundeck-plugins/build-zip/master/build.gradle'

Every time we update that file in github, it is no longer possible for users to build their plugins from the same original source.

Also, if their build system does not have external internet access, the build can never succeed, unless they figure out how to cache this code somewhere that gradle will find and use it--I'm not sure if that's possible?

We should, as part of building this tool, include a static, versioned copy of all required code to ensure that the results of what it builds are deterministic and cannot be compromised without leaving a clear trace.

@plambert plambert changed the title The build.gradle should not pull in unversioned, remote code The build.gradle in the template should not pull in unversioned, remote code Oct 25, 2018
@plambert plambert changed the title The build.gradle in the template should not pull in unversioned, remote code The build.gradle in the templates should not pull in unversioned, remote code Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant