You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
If you are interested in working on this issue or have submitted a pull request, please leave a comment.
Overview of the Issue
Approval by non-codeowner allows the apply and fails to merge
Reproduction Steps
The github repo has codeowners
The branch protections enforce codeowners
The pr was approved by a NON codeowner
atlantis apply was commented
terraform apply was run (which shouldn't have happened)
pr failed to merge
atlantis/apply pr check is in a failed state
Logs
n/a
Environment details
0.27.2
Additional Context
n/a
The text was updated successfully, but these errors were encountered:
Atlantis cannot reflect every single permutation of what people consider a PR to be ok to be applied/merged, but GitHub can. So I guess right way forward is to use mergeable as apply_requirement and configure everything else in branch protection/rulesets.
Community Note
Overview of the Issue
Approval by non-codeowner allows the apply and fails to merge
Reproduction Steps
The github repo has codeowners
The branch protections enforce codeowners
The pr was approved by a NON codeowner
atlantis apply was commented
terraform apply was run (which shouldn't have happened)
pr failed to merge
atlantis/apply pr check is in a failed state
Logs
n/a
Environment details
0.27.2
Additional Context
n/a
The text was updated successfully, but these errors were encountered: