Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bundler::Audit::Scanner#initialize #181

Open
postmodern opened this issue Oct 12, 2017 · 4 comments · May be fixed by #224
Open

Refactor Bundler::Audit::Scanner#initialize #181

postmodern opened this issue Oct 12, 2017 · 4 comments · May be fixed by #224

Comments

@postmodern
Copy link
Member

Looking at #initialize now, it seems that it should accept the scanner options (:ignore) and store those as instance variables. The #scan method would then accept the path to the Gemfile.lock. This would allow the Scanner object to be configured once and ran across multiple Gemfile.lock files.

@postmodern
Copy link
Member Author

Would this be relevant to @mveytsman and @phillmv's interests?

@picatz
Copy link

picatz commented Oct 22, 2017

This may be partially related to #182

@daveallie
Copy link

daveallie commented Feb 28, 2018

Interested in this. Working through the process of upgrading a production app, and currently have the app booting 2 versions of Rails. Each version is run off different bundler lockfiles, Gemfile.lock, and GemfileNext.lock. Would love for a way to supply a list of lockfiles to check or just basic cli support for custom lockfile path. If you're interested in the latter (even though it will most likely clash with this issue), please let me know and I'll submit a PR.

@postmodern
Copy link
Member Author

@daveallie Linking my comment on scanning multiple Gemfile.lock in one go vs. multiple CI runs:
#224 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants