-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby with --with-sitedir=no
configuration
#7414
Labels
Comments
There actually are small traces of handling the missing vendor dir. That means also JRuby might struggle to pass these test cases and indeed, the whole test file is just disabled:
This is related to the following test failure:
Where the hidden reason for the test failure is this exception:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I am trying to prepare minimal and self contained Ruby RPM package. Therefore I chose to configure Ruby using
--with-sitedir=no --with-vendordir=no
configuration options. And now I am facing test suite errors such as:If I understand correctly, the
$(sitedir)
actually comes from here:rubygems/lib/rubygems/commands/setup_command.rb
Lines 449 to 462 in 4198033
In normal situation, with the default site dir configuration, the
RbConfig::CONFIG[site_or_vendor]
would be expanded into proper path. However, with disabled site dir, theRbConfig
does not have value for thesitedir
, therefore the$(sitedir)
is kept. It seems that the Ruby'srbinstall.rb
script handles this scenario:https://github.com/ruby/ruby/blob/a846d391d38b34fcc4f90adef967c166c923bd56/tool/rbinstall.rb#L354-L361
IOW, I don't think this is just test suite error. The test suite error correctly points out that there might be user scenario, which is not correctly handled (is it trying to update RubyGems via
gem update
?). If this is valid Ruby configuration, I believe that RubyGems should properly handle this situation (even if "properly" was just reporting that there is no location for updated RubyGems).The text was updated successfully, but these errors were encountered: