added feature_spec_helper to turn on javascript driver, added test fo… #132
Conversation
…r pledge button opening up a new tab
| @@ -1,4 +1,4 @@ | |||
| require "rails_helper" | |||
| require "features_helper" | |||
There was a problem hiding this comment.
Did you forget to commit this file? It doesn't exist in the project.
There was a problem hiding this comment.
Thanks for the PR!
I'll second filipewl's review (looks like you're missing a file), but I've got something else too:
I'm not thrilled with the idea of using another file instead of rails_helper for specific feature tests; let's keep it to one root configuration file. Could you move your configuration to a spec support file? This will involve creating a support file (ex. spec/support/capybara.rb) and importing it in spec/rails_helper.rb.
|
Are you still working on this issue? |
|
I'm going to close this PR and free the issue. If you're still working on this, comment and we can re-open it. |
|
I'll work on it this evening, I was called into jury duty last week and it went right up until a 4 day vacation so I was offline for a while. |
|
Sure thing–I hope you enjoyed your vacation! I'll reopen the PR. |
|
I'm going to close this PR since it's been unchanged for a few months. Let me know if it should be reopened! |
…r pledge button opening up a new tab
Resolves #131
Make sure you've covered the following bases in your PR. They won't all be
needed for every PR (ex. fixing a straightforward rubocop issue might have no
tradeoffs and add no dependencies).
What were the main changes/goals of this PR?
To add javascript enabled feature tests, and test the pledge to donate button opening up on a new tab.
Did you need to make any tradeoffs? Why did you make the choice you made?
it opens up amazon.com in the next tab. this should still work even if you can't connect to the internet.
Did you add any dependencies?
no, selenium was already a dependency.
Anything else we should know about?