Skip injecting extensions on frame switch to prevent javascript errors #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected by ferrum on page load
|
This was exactly the issue in the past as they weren't injected, in other words this is a workaround, I'll double check if Chrome fixed this. Seems like this test isn't accurate because it doesn't check if there are extensions available in the frame. |
|
Any info on this? Or should this be handled in ferrum? extension_digest = Digest::SHA256.hexdigest(extension)
extension_wrapper = <<~JS
window._ferrum_loaded_extensions ||= [];
if (window._ferrum_loaded_extensions.indexOf("#{extension_digest}") == -1) {
window._ferrum_loaded_extensions.push("#{extension_digest}");
#{extension}
}
JS
command("Page.addScriptToEvaluateOnNewDocument", source: extension_wrapper)
[...] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200.
The extensions were injected again on every frame switch. That seemed unnecessary to me as they were already injected on page load by ferrum.
This resulted in some javascript errors, because some constants were redefined by the default cuprite extension.
This change fixes this problem and there does not seem to be anything missing inside the frames.