-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAtomicFixnum should probably be a private constant #981
Comments
Given #986, it seems important to communicate very clearly which classes are internal, e.g., using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Otherwise we get misleading suggestions from did-you-mean in case
concurrent/atomic/atomic_fixnum
is not required but the extension is loaded like:Note that even if it's private, did-you-mean is still kind of misleading:
And there are various specs checking
defined? Concurrent::CAtomicFixnum
and even a benchmark referencing Concurrent::CAtomicFixnum, so it's not so easy to make it private unfortunately.Unclear if worth fixing. WIP at master...eregon:concurrent-ruby:private-AtomicFixnum
The text was updated successfully, but these errors were encountered: