-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSpec/Capybara/FeatureMethods auto-correct is not safe #1753
Comments
jeppester
changed the title
RSpec/Capybara/FeatureMethods safe autocorrect is not safe
RSpec/Capybara/FeatureMethods auto-correct is not safe
Nov 21, 2023
memo) |
Or the cop should not auto-correct top-level groups. Thanks for reporting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the following file:
RSpec/Capybara/FeatureMethods
will auto-correct to:But that correction is not safe, since the example group now no longer has
type: :feature
, which can lead to certain helpers not getting loaded (which is how I discovered the issue).Either the correction should lead to
type: :feature
getting added:Or the cop should not have auto-correct marked as safe.
Rubocop version: 1.57.2
Rubocop-rspec version: 2.25.0
The text was updated successfully, but these errors were encountered: