-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilePath deficiencies #1701
Comments
In the following case, I often use rspec-request_describer to write a request spec. So in the case of String, I don't think it will necessarily match the file path. WDYT? Is there a way to know that in the case of string, it always indicates Class? RSpec.describe 'MyClass' do |
Why? I like it more descriptive and human-readable, with explicit URL defined in ‘def request’ or |
rspec-request_describer is a plugin for RSpec, but it is useful to use it as follows, but if you use such a plug-in, it may not be a big problem because Exclude will not change the behavior in the first place before and after the change # `RSpec::RequestDescriber` provides `subject` from its top-level description.
# subject will be `get('/users')`.
RSpec.describe 'GET /users' do
it 'returns 200' do
subject
expect(response).to have_http_status(200)
end
end |
RSpec/FilePath
intoRSpec/SpecFilePathSuffix
andRSpec/SpecFilePathFormat
#1698 (comment)Would it detect:
RSpec/FilePath
intoRSpec/SpecFilePathSuffix
andRSpec/SpecFilePathFormat
#1698 (comment) refactor to avoid nested loops?The text was updated successfully, but these errors were encountered: