-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When the tests do not produce TAP output, unitest hangs indefinitely on browser tests only. #4
Comments
By default, electron will run indefinitely unless explicitly closed. This is a similar issue to max-mapper/electron-spawn#17 After a quick search I found the following issue (for being able to check if the event loop is empty in electron) but it was marked as wontfix: electron/electron#2358
A default timeout for electron tests could be added, I suppose. |
I think a warning should be logged if no browser test output is found after 5 seconds. This would make it obvious as to why tests would be hanging. |
If the test script doesn't produce TAP output, the
--browser
tests will hang indefinitely. This does not affect the--node
tests.To demonstrate, create a blank file
not-tap-output.js
or put some code in it that doesn't produce a tap output:The text was updated successfully, but these errors were encountered: