Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DatePicker,DateRangePicker): fix the issue that renderValue does not work #3798

Merged
merged 1 commit into from
May 15, 2024

Conversation

simonguo
Copy link
Member

@simonguo simonguo commented May 13, 2024

In #3515 #3525, in order to support entering dates via the keyboard, renderValue was deprecated. However, in actual business scenarios, format cannot completely replace renderValue to render values personalized, so renderValue will be re-enabled.

fix: #3794
fix: #3795

Copy link

codesandbox bot commented May 13, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rsuite-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:45am
rsuite-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 9:45am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rsuite-v4 ⬜️ Ignored (Inspect) May 13, 2024 9:45am

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.88%. Comparing base (980487c) to head (0cab5f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3798   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         661      661           
  Lines       22843    22863   +20     
  Branches     3093     3099    +6     
=======================================
+ Hits        21446    21466   +20     
  Misses        709      709           
  Partials      688      688           
Flag Coverage Δ
ChromeCi 93.84% <100.00%> (+<0.01%) ⬆️
Firefox 93.22% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonguo simonguo merged commit 494c9c6 into main May 15, 2024
16 checks passed
@simonguo simonguo deleted the fix/date-picker-value branch May 15, 2024 01:42
@vendramini
Copy link

Any plans to release it? I have a very specific use-case to customize the value. Thank you :)

@simonguo
Copy link
Member Author

Any plans to release it? I have a very specific use-case to customize the value. Thank you :)

Released to v5.61.0. rsuite is updated every Friday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants