Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated AMS template #298

Open
eliocamp opened this issue Jul 6, 2020 · 7 comments · May be fixed by #444
Open

Outdated AMS template #298

eliocamp opened this issue Jul 6, 2020 · 7 comments · May be fixed by #444
Labels
help wanted ❤️ we'd love your help!

Comments

@eliocamp
Copy link
Contributor

eliocamp commented Jul 6, 2020

The American Meteorological Society now has a new version of their LaTeX template (https://www.ametsoc.org/ams/index.cfm/publications/authors/journal-and-bams-authors/latex-author-info/) and some new guidelines (such as adding a significance statement).

I'm updating the article template but how does rticles manage these kinds of breaking changes? Do you just replace the old skeleton and template with the new one or should I create an amsV5_article, or maybe replace ams_article but preserve the old behaviour in an ams_article_old?

@yufree
Copy link
Contributor

yufree commented Jul 6, 2020

As long as no AMS journal will accept the old template, I think it's fine to replace the outdated one.

@eliocamp
Copy link
Contributor Author

eliocamp commented Jul 8, 2020

Part of the guidelines of the AMS is to use the \appendcaption instead of \caption for appendix figures. Right now, there is no easy way of changing the caption command, and even if there were (I've opened an issue in knitr) it wouldn't help in this particular case because the syntax of both commands are slightly different.

What I'm doing now, as I dogfood myself by writing an article using this template, is to have a chunk at the top of the document that defines and sets a new plot hook. You can see it here.

It works, but is not very user-friendly. Would it be acceptable to add that custom plot hook function as a function inside rticles?

@yihui
Copy link
Member

yihui commented Jul 8, 2020

It works, but is not very user-friendly. Would it be acceptable to add that custom plot hook function as a function inside rticles?

That's okay. We have done that with other article formats in this package.

@eliocamp
Copy link
Contributor Author

eliocamp commented Jul 8, 2020

Oh! I looked at more of the codebase. I hadn't realised that the ams_article() function could add hooks! That's great! I'll do that.

@cderv cderv modified the milestone: v0.16 Aug 12, 2020
@cderv cderv linked a pull request Jun 9, 2021 that will close this issue
@cderv cderv added help wanted ❤️ we'd love your help! and removed help wanted labels Jul 19, 2021
@cderv
Copy link
Collaborator

cderv commented Sep 7, 2021

@eliocamp sorry for the delay on this one.

AMS has now updated to template V6.
https://www.ametsoc.org/index.cfm/ams/publications/author-information/latex-author-info/

Regarding #348 I believe we should not merge V5 maybe but try V6 directly for an update ?

I know we are way longer than we should to merge PR but I am catching up currently for next CRAN release.

@yufree @eliocamp What are your thoughts on this ?
Is one of you still publishing to AMS ?

@eliocamp
Copy link
Contributor Author

eliocamp commented Sep 7, 2021

I'm not. We moved to Climate Dynamics. I do agree that with V6 out, then it only makes sense to implement that version directly instead of V5.

@yufree
Copy link
Contributor

yufree commented Sep 7, 2021

I'm not. I think we can change to V6 in #348 or a new PR.

@ConorIA ConorIA linked a pull request Oct 17, 2021 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted ❤️ we'd love your help!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants