Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible line height issue #700

Closed
amk221 opened this issue Apr 8, 2024 · 2 comments
Closed

Possible line height issue #700

amk221 opened this issue Apr 8, 2024 · 2 comments

Comments

@amk221
Copy link

amk221 commented Apr 8, 2024

Describe the bug
I am trying to move from Helvetica Neue to Inter, but there is a situation that produces what visually feels like 1 pixel jump in the line height.

Possibly related to #361

Slice 1



To Reproduce
https://jsfiddle.net/amk221/swyb1m83/

Expected behavior
Line height should not jump

Screenshots
See fiddle

Environment

@rsms
Copy link
Owner

rsms commented May 24, 2024

As expected. You likely need to do something different with HTML and/or CSS. The web platform is quite complex.

You can explore line height here:
https://rsms.me/inter/lab/?draw-sample-bg=1&lineHeight=196&sample=Moj&size=128

Screen Shot 2024-05-24 at 11 09 57 Screen Shot 2024-05-24 at 11 11 50

Also "line height" is complicated; some related reading: https://www.figma.com/blog/line-height-changes/

@rsms rsms closed this as completed May 24, 2024
@amk221
Copy link
Author

amk221 commented May 28, 2024

Great tool thank you.

If I enable "Compare with System font", it actually demonstates the problem, if you set the font size to 12px. It's not vertically aligned

Screen.Recording.2024-05-28.at.10.59.16.mov

Screenshot 2024-05-28 at 11 03 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants