-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Config: ignore specific modules on Credo.Check.Readability.AliasAs #81
Comments
@rrrene I'm happy to work on it if you think that's a nice addition. |
I would absolutely merge this! 👍 |
Nice, working on it then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What do you want Credo to do?
Today the
Credo.Check.Readability.AliasAs
errors for any use of the:as
option on aliases. My problem with that is that there are some module that you don't have control over their names and they're poorly named to not use the:as
option.In my case, specifically the module
MyAppWeb.Router.Helpers
fromPhoenix
, if I don't useas: Routes
option like the suggested by phoenix generator, we should be usingHelpers.page_path(conn, :index)
, which is a lot less clear thanRoutes.page_path(conn, :index)
.Which existing behaviour would change?
There would not be any backwards incompatible change. The only thing would be that one would be able to set something like
{Credo.Check.Readability.AliasAs, ignore: [MyAppWeb.Router.Helpers]}
on.credo.exs
and all modules on this list would be ignored on this check.The text was updated successfully, but these errors were encountered: