Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol’s function definition is void: dnd-unescape-uri #5

Open
artelse opened this issue Apr 1, 2022 · 3 comments
Open

Symbol’s function definition is void: dnd-unescape-uri #5

artelse opened this issue Apr 1, 2022 · 3 comments

Comments

@artelse
Copy link

artelse commented Apr 1, 2022

When I drop a pdf onto my bibliography.org buffer, I get this error:
Symbol’s function definition is void: dnd-unescape-uri

According to the discussion on org-ref this function has been renamed with a double dash. Kitchin provides a fix here.
I simply renamed the function with a double dash dnd--unescape-uri which indeed fixes the problem.

@rougier
Copy link
Owner

rougier commented Apr 8, 2022

Oh nice. Could you make a PR ? You should check if dnd-unescape-uri is bound and if not, then use dnd--unescape-ui.

@artelse
Copy link
Author

artelse commented Apr 8, 2022

In the linked org-ref discussion, checking for dnd-unescape-uri seems not feasible because it needs to be loaded first which not always seems the case. I forked this repo with a few corrections on obvious warnings. I did this as an exercise to learn more about elisp. For me just replacing it with the double dash function works for now.

@rougier
Copy link
Owner

rougier commented Apr 8, 2022

org-ref fix might be agood option. I need first to push a bunch of changes I've made and then I'll include it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants