Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ido missing applied themes #36

Open
scottlindeman opened this issue Sep 22, 2022 · 1 comment
Open

Ido missing applied themes #36

scottlindeman opened this issue Sep 22, 2022 · 1 comment

Comments

@scottlindeman
Copy link

Hello!

In the nano-emacs project, ido-mode is properly themed. However in this new nano-theme project those lines are missing form the custom-theme-set-faces input and we are left with the default red and green foreground text.

The following was in nano-emacs:

(defun nano-theme--ido ()
  "Derive ido faces from nano faces."
  (with-eval-after-load 'ido
    (set-face 'ido-first-match                       'nano-face-salient)
    (set-face 'ido-only-match                          'nano-face-faded)
    (set-face 'ido-subdir                             'nano-face-strong)))

Unless there are any changes you'd like to see, I can make a PR that applies those faces.

Great theme by the way!

@rougier
Copy link
Owner

rougier commented Oct 1, 2022

Many thanks! Could you make a PR after having signed the copyright assignment (not needed if you already signed it)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants