Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org-table use nano-dark-faded which makes reading difficult in nano-dark #35

Open
arael opened this issue Sep 12, 2022 · 7 comments
Open

Comments

@arael
Copy link

arael commented Sep 12, 2022

The tables in nano-dark are too difficult to read. Is there any way to decouple the nano-dark-faded from org-table colors?

table

@arael arael changed the title Org-table use org-faded which makes reading difficult in nano-dark Org-table use nano-dark-faded which makes reading difficult in nano-dark Sep 12, 2022
@rougier
Copy link
Owner

rougier commented Sep 12, 2022

What is the face used ? We would modify this face specifically in the theme.

@arael
Copy link
Author

arael commented Sep 13, 2022

The face is called 'org-table'. Every field in 'unspecified' except 'inherit' which is set to 'nano-faded'.

@arael
Copy link
Author

arael commented Sep 13, 2022

May I bother you also for 'italic'? Just like 'org-table' it is difficult to read. All the fields are set to 'unspecified' except 'inherit' which is 'nano-faded'.

Thank you very much!

@arael
Copy link
Author

arael commented Sep 14, 2022

Fixed with custom-set-face function like this:

(use-package nano-theme
    :ensure t
    :config
    (custom-set-faces
        '(italic ((t (:inherit nano-salient))))
        '(org-table ((t (:inherit nano-default)))))
  )
  (load-theme 'nano-dark t)

@rougier
Copy link
Owner

rougier commented Sep 22, 2022

Thanks. Could you post a screenshot before/after?

@arael
Copy link
Author

arael commented Sep 22, 2022

Sure.

This is before:
before

And this is after:
after

@rougier
Copy link
Owner

rougier commented Oct 1, 2022

Perfect, thanks. Can you make a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants