-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having nano-emacs around breaks building other modules #84
Comments
Thanks for the report. I'm now trying to clean things up by splitting packages into individual repositories (nano-theme, modeline and splash so far) and I need to separate the actual layout from other settings. |
That's an excellent idea, thank you!! By the way, thank you for your talk with https://inacheve-dimprimer.net/. That was inspiring and I'm trying to cleanup my Emacs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are 2 problems in nano-emacs code base that breaks my borg-based setup:
nano-defaults.el
has top-level instructions with side effect: e.g.,(setq-default shell-file-name "/bin/zsh")
. This means that loading the file changes Emacs. I suggest wrapping these changes in anano-defaults
function.nano-defaults.el
mixes general-purpose improvements and user-specific configuration (e.g., your email address, name and favorite shell). I suggest moving your configuration to a dedicated file outside of this repository.My actual problem is that batch compiling my Emacs packages loads
nano-defaults.el
which changes the default shell to/bin/zsh
(which I don't have) and this breaks compiling a subsequent Emacs package.The text was updated successfully, but these errors were encountered: