-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nano-minibuffer implicitly depends on nano-color #80
Comments
Good catch, thank you. I think option 3 might be the best and the most compatible with dark/light themes. If you can make a PR that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The optional
nano-minibuffer.el
usesmaterial-color
on L54 but does not explicitly loadnano-colors.el
which is another optional module and therefore causes a backtrace error if your init file doesn't already requirenano-colors
.For ease of use by new emacs users, I think it would be better if:
nano-minibuffer.el
in the README thatnano-colors.el
is also required and must be loaded first, ornano-colors.el
is explicitly loaded bynano-minibuffer.el
, ormaterial-color
with one fromnano-basecolors.el
.I'll happily make an MR if you have an opinion about which of these options you'd like to see merged.
The text was updated successfully, but these errors were encountered: