Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish shell support #128

Open
rossmacarthur opened this issue Jan 10, 2022 · 5 comments
Open

Fish shell support #128

rossmacarthur opened this issue Jan 10, 2022 · 5 comments
Labels
feature New feature or request

Comments

@rossmacarthur
Copy link
Owner

No description provided.

@rossmacarthur rossmacarthur added the feature New feature or request label Jan 10, 2022
@yonkeltron
Copy link

Just wanted to throw my support behind this feature, I'm a huge fan of Fish and would love to help test this out!

@rossmacarthur
Copy link
Owner Author

I have added experimental support for this in 8ba75aa which will be released in 0.7.2. Any help testing would be greatly appreciated

@yonkeltron
Copy link

Hey I'm all over this. Cloning the source now so I can take a crack at it. Let's see how it goes!

@rossmacarthur
Copy link
Owner Author

I've already noticed some problems 😅 and actually I wasn't sure about the design for this. It seems that fish plugins are generally well structured they have:

  • conf.d
  • completions
  • functions

but I wasn't sure if the scripts should be sourced or if they should just be symlinked to the ~/.config/fish/ directories. conf.d generally needs to be executed before ~/.config/fish/config.fish so that would be an argument doing that.

@yonkeltron
Copy link

Happy to consult a bit more on this since there are two different approached, which are largely compatible. One is Oh My FIsh whereas the other is the lighter-weight Fisher. Does this help? How can I help more?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants